Skip to content

Commit

Permalink
dongjiang, change go-cmp to reflect
Browse files Browse the repository at this point in the history
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
  • Loading branch information
dongjiang1989 committed Apr 18, 2024
1 parent 7cebf0b commit bfbe25e
Showing 1 changed file with 2 additions and 28 deletions.
30 changes: 2 additions & 28 deletions prometheus/testutil/testutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import (
"net/http"
"reflect"

"github.com/google/go-cmp/cmp"
dto "github.com/prometheus/client_model/go"
"github.com/prometheus/common/expfmt"
"google.golang.org/protobuf/proto"
Expand Down Expand Up @@ -277,37 +276,12 @@ func compare(got, want []*dto.MetricFamily) error {
return fmt.Errorf("encoding expected metrics failed: %w", err)
}
}
if diffErr := diff(gotBuf.String(), wantBuf.String()); diffErr != "" {
return fmt.Errorf(diffErr)
if diffErr := reflect.DeepEqual(gotBuf, wantBuf); !diffErr {
return fmt.Errorf("metrics diff")
}
return nil
}

// diff returns a diff of both values as long as both are of the same type and
// are a struct, map, slice, array or string. Otherwise it returns an empty string.
func diff(expected, actual interface{}) string {
if expected == nil || actual == nil {
return ""
}

et, ek := typeAndKind(expected)
at, _ := typeAndKind(actual)
if et != at {
return ""
}

if ek != reflect.Struct && ek != reflect.Map && ek != reflect.Slice && ek != reflect.Array && ek != reflect.String {
return ""
}

diff := cmp.Diff(expected, actual)
if diff == "" {
return ""
}

return "\n\nDiff:\n" + diff
}

// typeAndKind returns the type and kind of the given interface{}
func typeAndKind(v interface{}) (reflect.Type, reflect.Kind) {

Check failure on line 286 in prometheus/testutil/testutil.go

View workflow job for this annotation

GitHub Actions / lint

func `typeAndKind` is unused (unused)
t := reflect.TypeOf(v)
Expand Down

0 comments on commit bfbe25e

Please sign in to comment.