Fix thread state metrics not being exposed #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnapster
force-pushed
the
patch-1
branch
3 times, most recently
from
1ee9d42
to
f7dc31c
Compare
Signed-off-by: Dennis Neufeld <napster@npstr.space>
Signed-off-by: Dennis Neufeld <napster@npstr.space>
|
I have also expanded the test case to cover the thread state metric. I'm new to Mockito, hope my test code fits this project's expectations. |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brian-brazil
#391 introduced thread state metrics, however while they are collected, they are not actually exposed. Adding this line should fix that.