Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram: Add a doc comment about when to add a no-op span #67

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jul 20, 2023

@beorn7 beorn7 requested a review from bwplotka July 20, 2023 16:41
See prometheus/client_golang#1127 for details.

Signed-off-by: beorn7 <beorn@grafana.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@beorn7 beorn7 merged commit cfbcccb into master Jul 26, 2023
3 checks passed
@beorn7 beorn7 deleted the beorn7/histogram branch July 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants