-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
histogram support for ruby client #24
Conversation
# HELP xuq xuq description | ||
xuq{code="ah",le="10"} 1 | ||
xuq{code="ah",le="20"} 2 | ||
xuq{code="ah",le="30"} 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must expose a +Inf bucket wit the same value as _count
:histogram | ||
end | ||
|
||
def add(labels, value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be called observe
Thanks for your contribution! This looks great in general, please only fix the last few comments. I updated the formatting to the latest rubocop rules (not sure following rubocop was a good idea, they change their mind so often ...). Please rebase and squash your changes against current master. I'll fix the test dependencies for "old" ruby versions tomorrow. |
Hi @grobie @brian-brazil, I have updated my PR, please kindly check it |
Thanks a lot @rolandhawk! |
Is this acceptable?
ref #21