Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths including numeric IDs by default #62

Merged
merged 1 commit into from
May 30, 2017

Conversation

grobie
Copy link
Member

@grobie grobie commented May 30, 2017

Quite a few people run into the issue of creating too many time series
by exporting an unbounded number of paths label values. While it's
documented and possible to provide a custom label builder, a better
default is probably to always normalize ids in HTTP paths.

@SuperQ @brian-brazil

Quite a few people run into the issue of creating too many time series
by exporting an unbounded number of paths label values. While it's
documented and possible to provide a custom label builder, a better
default is probably to always normalize ids in HTTP paths.
@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage remained the same at 98.997% when pulling ee2f9fe on grobie/sanitize-http-path-by-default into 3bdeb26 on master.

@brian-brazil
Copy link

👍

@grobie grobie merged commit 4b6b972 into master May 30, 2017
@grobie grobie deleted the grobie/sanitize-http-path-by-default branch May 30, 2017 18:05
@SuperQ
Copy link
Member

SuperQ commented May 30, 2017

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants