Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Rack configuration #83

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Updated Rack configuration #83

merged 1 commit into from
Apr 16, 2018

Conversation

jamtur01
Copy link
Contributor

@jamtur01 jamtur01 commented Mar 1, 2018

In newer rack versions the if guard fails with a missing method for
.any?. The quickest fix is to remove the guard.

@jamtur01
Updated Rack configuration
85a6206 
In newer rack versions the if guard fails with a missing method for
`.any?`. The quickest fix is to remove the guard.
@jamtur01
Copy link
Contributor Author

jamtur01 commented Mar 1, 2018

Fixes #67

@coveralls
Copy link

coveralls commented Mar 1, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.667% when pulling 85a6206 on jamtur01:rackc into e9f6590 on prometheus:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.667% when pulling 85a6206 on jamtur01:rackc into e9f6590 on prometheus:master.

grobie
grobie approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@grobie grobie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, in the end it's just an example. Thank you!

@grobie grobie merged commit 2b3a0c7 into prometheus:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobie grobie grobie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamtur01 @coveralls @grobie