Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SendEncodeMetric with SendSyncEncodeMetric #58

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Mar 29, 2022

This will allow the default Registry to be used in multi-threaded
environments (e.g. web servers) where the registry needs to be shared
between threads.

Closes #57.

This will allow the default `Registry` to be used in multi-threaded
environments (e.g. web servers) where the registry needs to be shared
between threads.

Closes prometheus#57.

Signed-off-by: Ben Sully <ben.sully@grafana.com>
Signed-off-by: Max Inden <mail@max-inden.de>
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sd2k!

@mxinden mxinden merged commit eef56cf into prometheus:master Apr 6, 2022
ackintosh pushed a commit to ackintosh/client_rust that referenced this pull request Aug 27, 2022
This will allow the default `Registry` to be used in multi-threaded
environments (e.g. web servers) where a ref to the registry needs
to be shared between threads.

Closes prometheus#57.

Signed-off-by: Ben Sully <ben.sully@grafana.com>

Signed-off-by: Max Inden <mail@max-inden.de>

Co-authored-by: Max Inden <mail@max-inden.de>
Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing dynamically dispatched registry in web framework state
2 participants