Allow rule labels with slash

[gordonbondon]

Spec for PrometheusRule notes that labels may match selectors of replication controllers and services. According to this labels like app.kubernetes.io/name are recommended for kubernetes. But apparantly / is not allowed here and I get errors like this:

level=error ts=2019-03-21T14:32:57.642600466Z caller=manager.go:754 component="rule manager" msg="loading groups failed" err="group \"analytics-csgo-stats-api-dev.rules\", rule 0, \"5xxErrors\": invalid label name: app.kubernetes.io/name"

[brian-brazil]

You've got the wrong repo, you're looking for the Prometheus Operator.

[gordonbondon]

Operator does not validate rules itself. So I get this error when rule is added prometheus config and probably bparsed by this package here.

I understand that prometheus is not part of kubernetes but still,
is it possible to allow / symbols so it's possible to use such labels? Or there is some limitation?

[brian-brazil]

The characters allowed in labelnames will not change from a Prometheus standpoint. This does sound like an Operator issue.

[gordonbondon]

Sorry, I did not provide more details. I was meant rules labels like here:

- name: somename
      rules:
        - alert: "AnalyticsCsgoStats5xxErrors" 
          annotations:
            description: "Increased 5xx error rate on {{ $labels.namespace }}/{{ $labels.service }}"
            expr: increase(analytics_csgo_stats_http_responses_total{code=~"5.*"}[1m]) > 0
          for: "5m"
          labels:
            severity: "warning"
            app.kubernetes.io/name: app-name

Currently, we have to switch app.kubernetes.io/name to app because / is not allowed.

[brian-brazil]

Dot isn't allowed either, it's on you to keep within the permitted label names.

…

On Thu 21 Mar 2019, 17:00 Artem Iarmoliuk, ***@***.***> wrote: Sorry, I did not provide more details. I was meant rules labels like here: - name: somename rules: - alert: "AnalyticsCsgoStats5xxErrors" annotations: description: "Increased 5xx error rate on {{ $labels.namespace }}/{{ $labels.service }}" expr: increase(analytics_csgo_stats_http_responses_total{code=~"5.*"}[1m]) > 0 for: "5m" labels: severity: "warning" app.kubernetes.io/name: app-name Currently, we have to switch app.kubernetes.io/name to app because / is not allowed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#180 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGyTdqyxyLDbCneB-zegUnd8ZQLFDxgjks5vY7qjgaJpZM4cBm1Q> .

[gordonbondon]

Ok, I understand that it's not possible to change this. Thanks.

[abdennour]

any update ? we have label naming conventions for k8s, and we wanna use same for prom rule labels