Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using inlined fnv hasher for signature. #19

Closed
beorn7 opened this issue Nov 10, 2015 · 1 comment
Closed

Consider using inlined fnv hasher for signature. #19

beorn7 opened this issue Nov 10, 2015 · 1 comment
Assignees
@beorn7
Labels
enhancement

Comments

@beorn7
Copy link
Member

beorn7 commented Nov 10, 2015

As done in prometheus/client_golang#181, we can probably avoid some allocation churn and lock contention in signature.go.
@beorn7 beorn7 self-assigned this Nov 10, 2015
@alicebob
Copy link

#20 should do that!

@grobie grobie closed this as completed Nov 12, 2015
gouthamve pushed a commit to gouthamve/common that referenced this issue Jul 22, 2018
@tomwilkie
Merge pull request prometheus#19 from weaveworks/standard-server
ecc5a27 
Add cortex http/grpc server to common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beorn7 beorn7

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grobie @alicebob @beorn7