Add new counter for the listen_disabled_num memcached metric #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR: prometheus#33 Signed-off-by: Luca Toscano <ltoscano@wikimedia.org>
grobie
reviewed
Oct 8, 2018
There was a problem hiding this comment.
Great! Thanks for your contribution.
I'm not 100% happy with the metric name, but couldn't really come up with a better one either. Let's go with it.
Though, we should also export accepting_conns, probably as memcached_connections_accepting gauge. Otherwise it's not entirely possible to understand whether a server is currently accepting connections or not.
|
I wasn't happy with the name either but didn't find anything better :( Wouldn't it be better to add the metric only if #37 gets implemented? Otherwise it is not worth it in my opinion, since once memcached stops accepting connections then the prometheus exporter will not be able to connect and retrieve metrics. |
|
Fair point. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #33
Signed-off-by: Luca Toscano ltoscano@wikimedia.org