Report collector success/failure and duration per scrape. #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobie
approved these changes
Mar 16, 2017
| @@ -54,7 +57,7 @@ type NodeCollector struct { | |||
|
|
|||
| // Describe implements the prometheus.Collector interface. | |||
| func (n NodeCollector) Describe(ch chan<- *prometheus.Desc) { | |||
| scrapeDurations.Describe(ch) | |||
| ch <- scrapeDurationDesc | |||
brian-brazil
force-pushed
the
scrape-success
branch
from
f0b7114
to
5bff234
Compare
This is in line with best practices, and also saves us 63 timeseries on a default Linux setup.
brian-brazil
force-pushed
the
scrape-success
branch
from
5bff234
to
2a2edc7
Compare
SuperQ
approved these changes
Mar 16, 2017
champtar
added a commit
to champtar/packages
that referenced
this pull request
Nov 15, 2017
…ration per scrape follow prometheus/node_exporter#516 Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
champtar
added a commit
to champtar/packages
that referenced
this pull request
Nov 15, 2017
…ration per scrape follow prometheus/node_exporter#516 Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
champtar
added a commit
to champtar/packages
that referenced
this pull request
Dec 9, 2017
As prometheus-node-exporter-lua is a reimplementation of node_exporter, I'm using "collector" instead of "scraper" and renaming some collectors put each collector in a separate file report collector success/failure and duration per scrape (follow prometheus/node_exporter#516) allow to filter collectors using "collect[]" params (see https://github.com/prometheus/node_exporter#filtering-enabled-collectors) Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
champtar
added a commit
to champtar/packages
that referenced
this pull request
Dec 9, 2017
As prometheus-node-exporter-lua is a reimplementation of node_exporter, I'm using "collector" instead of "scraper" and renaming some collectors put each collector in a separate file report collector success/failure and duration per scrape (follow prometheus/node_exporter#516) allow to filter collectors using "collect[]" params (see https://github.com/prometheus/node_exporter#filtering-enabled-collectors) Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Feb 2, 2018
As prometheus-node-exporter-lua is a reimplementation of node_exporter, I'm using "collector" instead of "scraper" and renaming some collectors put each collector in a separate file report collector success/failure and duration per scrape (follow prometheus/node_exporter#516) allow to filter collectors using "collect[]" params (see https://github.com/prometheus/node_exporter#filtering-enabled-collectors) Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Feb 7, 2018
As prometheus-node-exporter-lua is a reimplementation of node_exporter, I'm using "collector" instead of "scraper" and renaming some collectors put each collector in a separate file report collector success/failure and duration per scrape (follow prometheus/node_exporter#516) allow to filter collectors using "collect[]" params (see https://github.com/prometheus/node_exporter#filtering-enabled-collectors) Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Feb 7, 2018
As prometheus-node-exporter-lua is a reimplementation of node_exporter, I'm using "collector" instead of "scraper" and renaming some collectors put each collector in a separate file report collector success/failure and duration per scrape (follow prometheus/node_exporter#516) allow to filter collectors using "collect[]" params (see https://github.com/prometheus/node_exporter#filtering-enabled-collectors) Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
lynxis
pushed a commit
to lynxis/packages
that referenced
this pull request
Jan 3, 2019
As prometheus-node-exporter-lua is a reimplementation of node_exporter, I'm using "collector" instead of "scraper" and renaming some collectors put each collector in a separate file report collector success/failure and duration per scrape (follow prometheus/node_exporter#516) allow to filter collectors using "collect[]" params (see https://github.com/prometheus/node_exporter#filtering-enabled-collectors) Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with best practices, and also saves us
63 timeseries on a default Linux setup.