Remove fixture files with Windows incompatible names #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix: Some fixture files for sysfs have names which are invalid on Windows. This breaks git checkout on Windows systems. As procfs is a depdency of client_golang, this breaks Windows builds on hundreds of projects. A nicer solution could rename all paths with characters invalid on some filesystems. Such a rename approach should ideally work with default tools available on OSX and Linux.
grobie
force-pushed
the
grobie/package-sysfx-fixtures
branch
from
f0739d3
to
2766405
Compare
|
👍 |
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
…-fixtures Remove fixture files with Windows incompatible names
bobrik
pushed a commit
to bobrik/procfs
that referenced
this pull request
Jan 14, 2023
Fixes for Process::fd() to better protect against disappearing links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix: Some fixture files for sysfs have names which are invalid on
Windows. This breaks git checkout on Windows systems. As procfs is a
depdency of client_golang, this breaks Windows builds on hundreds of
projects.
A nicer solution could rename all paths with characters invalid on some
filesystems. Such a rename approach should ideally work with default
tools available on OSX and Linux.
Fixes #54.
@brian-brazil @SuperQ @ideaship
As we currently broke Windows builds of any project not vendoring all dependencies and using procfs/client_colang/go-kit, I quickly put that together. Happy to change to a nicer solution later, but I won't be available for the next few days.