Cut v1.6.0 #554
Cut v1.6.0 #554
Conversation
Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
|
@SuperQ Note the new |
| // MetricFamily and unmarshals it into a proto message object first. Then it | ||
| // marshals both the expected and the got proto message into a binary protobuf, | ||
| // which it then compares. | ||
| func verifyMetricFamily(t *testing.T, expText string, got *dto.MetricFamily) { |
There was a problem hiding this comment.
I wonder if we should add this helper somewhere in common.
There was a problem hiding this comment.
Yes, we should consider moving it up when it gets used there, too. However, I'm not quite sure yet if this is really the right way to do it… maybe some deep comparison without the final marshaling would be better?
There was a problem hiding this comment.
The recommended way I saw was to use https://pkg.go.dev/github.com/google/go-cmp/cmp to compare with https://pkg.go.dev/google.golang.org/protobuf/testing/protocmp.
There was a problem hiding this comment.
Oooof… two more dependencies instead of zero… I'd say we leave it as is in this PR and take some more time to consider our options for prometheus/common.
There was a problem hiding this comment.
Yea, I'm not a fan of what this change requires.
Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
|
Thanks for all the hints. All done. |
|
@SuperQ I assume your comments are all addressed. I'll merge now and publish the release. You have 30 seconds to object. :-> |
No description provided.