vendor: update gosnmp #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably to pickup gosnmp/gosnmp#92
|
Thanks! |
SuperQ
added a commit
to SuperQ/snmp_exporter
that referenced
this pull request
Jun 6, 2017
* [FEATURE] Add Homepage on /. prometheus#135 * [IMPROVEMENT] Add ddwrt OIDs to generator. prometheus#147 * [IMPROVEMENT] Add synology OIDs to generator. prometheus#149, prometheus#154 * [IMPROVEMENT] Use lookup node's index label in the generator. prometheus#162 * [BUGFIX] Fix `authNoPriv` in config parsing. prometheus#141 * [BUGFIX] Update gosnmp vendoring to fix timeouts/errors. prometheus#139, prometheus#171
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably to pickup gosnmp/gosnmp#92
This was necessary to get the exporter to work against a tripplite PDU.
Without it, the scrape requests timeout, and I observed
.1.3.6.1.4.1.850.10.1.2.7.4.0=[inetaddr len!=4]when I tcpdumped snmp traffic due to the value of the ipaddress being wrong (snmpwalk prints it as 'IpAddress: 2.0.0.0').