Sourcery refactored master branch #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-62
to
+65
| if isinstance(other, ChainContext): | ||
| self.primary_map.maps[0:0] = other.primary_map | ||
| self.fallback_map.maps[0:0] = other.fallback_map | ||
| else: | ||
| if not isinstance(other, ChainContext): | ||
| return super().__ior__(other) | ||
| self.primary_map.maps[:0] = other.primary_map | ||
| self.fallback_map.maps[:0] = other.fallback_map |
There was a problem hiding this comment.
Function ChainContext.__ior__ refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] [×2] (
remove-redundant-slice-index)
Comment on lines
-221
to
+220
| if isinstance(chain, Chain): | ||
| return Chain(self, *chain) | ||
| else: | ||
| return Chain(self, chain) | ||
| return Chain(self, *chain) if isinstance(chain, Chain) else Chain(self, chain) |
There was a problem hiding this comment.
Function Node.next refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-11
to
+17
| class Message(TypedDict): # type: ignore | ||
| role: Role | ||
| content: str | ||
| name: NotRequired[str] | ||
|
|
||
| else: | ||
| from typing_extensions import NotRequired, TypedDict | ||
|
|
||
| class Message(TypedDict): | ||
| role: Role | ||
| content: str | ||
| name: NotRequired[str] | ||
| class Message(TypedDict): # type: ignore | ||
| role: Role | ||
| content: str | ||
| name: NotRequired[str] |
There was a problem hiding this comment.
Lines 11-22 refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if)
There was a problem hiding this comment.
This is wrong. These changes are introducing new static-type-checking failures.
Comment on lines
-87
to
+82
| match = is_message_start.match(line) | ||
| if match: | ||
| if match := is_message_start.match(line): |
There was a problem hiding this comment.
Function parse_chat_markup refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-62
to
+68
| if op == "if" or op == "for" or op == "while": | ||
| if op in ["if", "for", "while"]: | ||
| self._ops_stack.append(op) | ||
| self._flush() | ||
| self._builder.add_line(f"{inner}:") | ||
| self._builder.indent() | ||
|
|
||
| elif op == "else" or op == "elif": | ||
| elif op in ["else", "elif"]: |
There was a problem hiding this comment.
Function TemplateCore._on_special_token refactored with the following changes:
- Replace multiple comparisons of same variable with
inoperator [×2] (merge-comparisons)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!