Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Combined GitHub Status #333

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

mikian
Copy link
Contributor

@mikian mikian commented Feb 3, 2019

Allows to send Pronto test result as a single Github commit status
instead of single one per runner. This allows a nice and way to see
all possible runners at once, and also enforce easily that all pronto
messages is handled in PRs.

In action, instead of displaying:
screenshot 2019-02-03 at 14 57 41

this would allow to display all statuses as combined:
screenshot 2019-02-03 at 14 57 48

Allows to send Pronto test result as a single Github commit status
instead of single one per runner. This allows a nice and way to see
all possible runners at once, and also enforce easily that all pronto
messages is handled in PRs.
@doomspork doomspork requested a review from a team May 18, 2019 15:19
Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy @mikian! Apologizes for the delays on getting to you. I think this idea is great!

Before I merge I want to give the @prontolabs/core this final weekend to review. Come Monday, I'll merge either way 😁

@doomspork doomspork merged commit c7dca8e into prontolabs:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants