Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(passport): check JWT issuer claim #2378

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix(passport): check JWT issuer claim #2378

merged 2 commits into from
Jun 15, 2023

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Jun 7, 2023

Description

The application route functions need to provide the request origin as the
expected issuer claim.

Related Issues

Testing

  • Manual

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl self-assigned this Jun 7, 2023
@szkl szkl marked this pull request as draft June 7, 2023 13:46
@szkl szkl added the bug Indicates an unexpected problem or unintended behavior label Jun 7, 2023
@szkl szkl force-pushed the fix/passport/check-jwt-issuer branch 3 times, most recently from 5160eae to c6ac6c2 Compare June 8, 2023 19:59
@szkl szkl marked this pull request as ready for review June 8, 2023 20:02
@szkl szkl force-pushed the fix/passport/check-jwt-issuer branch 9 times, most recently from 806b829 to a8a5466 Compare June 14, 2023 19:38
@szkl szkl force-pushed the fix/passport/check-jwt-issuer branch from a8a5466 to eb52f38 Compare June 14, 2023 19:42
@szkl
Copy link
Contributor Author

szkl commented Jun 14, 2023

Updated.

@betimshahini betimshahini merged commit 6dc5523 into main Jun 15, 2023
@betimshahini betimshahini deleted the fix/passport/check-jwt-issuer branch June 15, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

@maurerbot maurerbot Awaiting requested review from maurerbot

Assignees

@szkl szkl

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(passport): Access token issued by custom domain works in rollup domains also
2 participants
@szkl @betimshahini