Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): Billing & Invoicing - page frame #2399

Merged
merged 14 commits into from
Jun 15, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jun 14, 2023

Description

  • Updated console page routing hierarchy
  • Implemented page skeleton for the billing page, including mock numeric values for displaying according to Figma.

Related Issues

Testing

  • Visual
  • Update const proAllotance = 3 and const proUsage = 2 in billing loader to match figma

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jun 14, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Jun 14, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review June 14, 2023 13:21
<Button btnType="secondary-alt" btnSize="sm">
<div className="flex flex-row items-center gap-3">
<Text size="sm" weight="medium" className="text-gray-700">
Compare plans
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to https://rollup.id/pricing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed

<TbReceipt2 size={24} className="mr-2" />
<div className="flex flex-row w-full items-center justify-between">
<Text size="sm" weight="medium">
Billing & Invoicing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be displayed at all and the route it's pointing to should be named more obscurely until we're done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out link & reversed route name 🤷‍♀️

<PlanFeatures
features={[
{
title: 'Custom Branding',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync up with @picassobanana on these, for desktop and mobile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced up, added mobile version

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/billing-&-invoicing-page-frame branch from f087c0e to 68aa7c1 Compare June 14, 2023 15:10
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/billing-&-invoicing-page-frame branch from 68aa7c1 to cbe29cb Compare June 15, 2023 07:59
@betimshahini betimshahini merged commit 7a95e1e into main Jun 15, 2023
@betimshahini betimshahini deleted the feat/console/billing-&-invoicing-page-frame branch June 15, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(console): Billing & Invoicing - page frame
2 participants