Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workers): merge access, account, address, edges, starbase #2442

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Jun 26, 2023

Description

Work in progress...

Related Issues

Testing

  • Manual

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl marked this pull request as draft June 26, 2023 12:41
@szkl szkl self-assigned this Jun 26, 2023
@szkl szkl added the dx Indicated a developer experience issue label Jun 26, 2023
@szkl szkl force-pushed the chore/workers branch 16 times, most recently from 092cfe1 to 1e11a5b Compare June 30, 2023 18:25
@szkl szkl closed this Jun 30, 2023
@szkl szkl deleted the chore/workers branch June 30, 2023 18:28
@szkl szkl restored the chore/workers branch June 30, 2023 18:30
@szkl szkl reopened this Jun 30, 2023
@szkl szkl force-pushed the chore/workers branch 7 times, most recently from 2233fa1 to 3182f77 Compare July 13, 2023 20:42
@szkl szkl force-pushed the chore/workers branch 10 times, most recently from 23dc05b to 6feedee Compare July 20, 2023 23:22
@szkl szkl marked this pull request as ready for review July 20, 2023 23:29
@szkl szkl force-pushed the chore/workers branch 9 times, most recently from e9fd0c3 to b7ecf6a Compare July 21, 2023 18:24
@maurerbot
Copy link
Contributor

closes #1897

@@ -13,5 +22,7 @@ SECRET_MICROSOFT_OAUTH_CLIENT_SECRET = ""
INTERNAL_TWITTER_OAUTH_CLIENT_ID = ""
SECRET_TWITTER_OAUTH_CLIENT_SECRET = ""

SECRET_ZERODEV_PROJECTID = ""
INTERNAL_CLOUDFLARE_ZONE_ID = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two appear twice in this file.

@@ -1,3 +1,11 @@
SECRET_JWK_CURRENT_KID = ''
SECRET_JWKS = '[]'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add INTERNAL_DKIM_SELECTOR

@betimshahini betimshahini merged commit eae2f7a into main Jul 24, 2023
@betimshahini betimshahini deleted the chore/workers branch July 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Indicated a developer experience issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(platform): DO migrator chore(platform): Rename Access nodes
3 participants