-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workers): merge access, account, address, edges, starbase #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
force-pushed
the
chore/workers
branch
16 times, most recently
from
June 30, 2023 18:25
092cfe1
to
1e11a5b
Compare
szkl
force-pushed
the
chore/workers
branch
7 times, most recently
from
July 13, 2023 20:42
2233fa1
to
3182f77
Compare
szkl
force-pushed
the
chore/workers
branch
10 times, most recently
from
July 20, 2023 23:22
23dc05b
to
6feedee
Compare
szkl
requested review from
Cosmin-Parvulescu,
maurerbot,
betimshahini and
poolsar42
July 20, 2023 23:28
szkl
force-pushed
the
chore/workers
branch
9 times, most recently
from
July 21, 2023 18:24
e9fd0c3
to
b7ecf6a
Compare
closes #1897 |
betimshahini
approved these changes
Jul 24, 2023
@@ -13,5 +22,7 @@ SECRET_MICROSOFT_OAUTH_CLIENT_SECRET = "" | |||
INTERNAL_TWITTER_OAUTH_CLIENT_ID = "" | |||
SECRET_TWITTER_OAUTH_CLIENT_SECRET = "" | |||
|
|||
SECRET_ZERODEV_PROJECTID = "" | |||
INTERNAL_CLOUDFLARE_ZONE_ID = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two appear twice in this file.
@@ -1,3 +1,11 @@ | |||
SECRET_JWK_CURRENT_KID = '' | |||
SECRET_JWKS = '[]' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add INTERNAL_DKIM_SELECTOR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in progress...
Related Issues
Testing
Checklist