Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): Groups and group user management #2461

Merged
merged 17 commits into from
Jul 10, 2023
Merged

feat(console): Groups and group user management #2461

merged 17 commits into from
Jul 10, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jul 7, 2023 •
edited
Loading

Description

  • Added groups endpoint to nav menu
  • Added group listing page + creation modal
  • Added group details page + invitation prototype modal
  • Added data models for identity groups, for invitations and functionality hook up
  • Updated list & list items to make them clickable
  • Updated modal to allow overflow parameter so that we can use context menus inside modals
  • Added new edge tag

Related Issues

Testing

  • Went through flows described in Figma and ticket

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Jul 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jul 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/groups-and-group-user-management branch from 4fcf4e6 to ddddca1 Compare July 10, 2023 07:34
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review July 10, 2023 10:33
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/groups-and-group-user-management branch from ddddca1 to 113dfc6 Compare July 10, 2023 13:49
szkl
szkl reviewed Jul 10, 2023
View reviewed changes
apps/console/app/routes/__layout/groups/$groupID/index.tsx Outdated
<div className="flex flex-row items-center gap-2">
<img
className="w-5 h-5"
src={getProviderIcons(selectedProvider) ?? undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's like undefined || undefined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that. I replaced the return type of the getProviderIcons with undefined instead of null. Should make for a bit more cleaner code.

szkl
szkl suggested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@szkl szkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just {false && <NavLink ... instead of commenting out in apps/console/app/components/SiteMenu/index.tsx?

I think new methods need authorization middlewares.

platform/account/src/jsonrpc/methods/identity-groups/getIdentityGroupMemberInvitations.ts Outdated
Comment on lines 42 to 43
const DOBinding = IdentityGroup.wrap(ctx.IdentityGroup)
const node = DOBinding.getByName(identityGroupURN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you define this in a utility module like others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a initIdentityGroupNodeByName method.

platform/account/src/nodes/identity-group.ts Outdated
addressType,
}: InviteMemberInput): Promise<void> {
const invitations =
(await this.state.storage.get<undefined | MemberInvitation[]>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(await this.state.storage.get<undefined | MemberInvitation[]>(
(await this.state.storage.get<MemberInvitation[]>(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined is added to the return type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed explicit cast

@Cosmin-Parvulescu
Copy link
Contributor Author

Could you just {false && <NavLink ... instead of commenting out in apps/console/app/components/SiteMenu/index.tsx?

I think new methods need authorization middlewares.

Added false && to the render

@szkl szkl merged commit 5bd9f8d into main Jul 10, 2023
@szkl szkl deleted the feat/console/groups-and-group-user-management branch July 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkl szkl szkl approved these changes

@maurerbot maurerbot Awaiting requested review from maurerbot

@betimshahini betimshahini Awaiting requested review from betimshahini

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(console): Groups and group user management
2 participants
@Cosmin-Parvulescu @szkl