chore(repo): Setup Posthog and Stripe Secrets #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poolsar42
changed the title
betimshahini
requested changes
Jul 14, 2023
.github/workflows/main-console.yaml
Outdated
| STRIPE_PRO_PLAN_ID | ||
| SECRET_POSTHOG_API_KEY | ||
| SECRET_STRIPE_API_KEY | ||
| SECRET_STRIPE_WEBHOOK |
There was a problem hiding this comment.
Add back the suffix _SECRET. As is, it can be interpreted to mean a secret stripe webhook, which this isn't.
poolsar42
force-pushed
the
chore/2472-setup-secrets
branch
from
e56c02d
to
971f8f9
Compare
poolsar42
force-pushed
the
chore/2472-setup-secrets
branch
from
694e99f
to
307c025
Compare
betimshahini
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames and replaces posthog and stripe sercrets
Related Issues
Testing
under
/gnillibin console do the manual testing of payments locally to test if new variables work correctly.Checklist