chore(domains): Cloudflare SSL removal when downgrading apps #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
force-pushed
the
chore/domains/cloudflare-SSL-removal-when-downgrading-apps
branch
from
245522a
to
4da616f
Compare
szkl
previously approved these changes
Jul 20, 2023
Comment on lines
302
to
310
| for (const app of reconciliations.filter((r) => r.customDomain)) { | ||
| try { | ||
| await starbaseClient.deleteCustomDomain.mutate({ | ||
| clientId: app.clientID, | ||
| }) | ||
| } catch (e) { | ||
| console.error(`Failed to delete custom domain for app ${app.clientID}`) | ||
| } | ||
| } |
There was a problem hiding this comment.
Would it be better to execute them asynchronously?
| @@ -83,6 +84,7 @@ export const reconcileAppSubscriptions = async ({ | |||
| devEmail: app.devEmail, | |||
| appName: app.app?.name ?? 'Undefined', | |||
| plan, | |||
| customDomain: app.customDomain ? true : false, | |||
There was a problem hiding this comment.
Suggested change
| customDomain: app.customDomain ? true : false, | |
| customDomain: Boolean(app.customDomain) |
Cosmin-Parvulescu
force-pushed
the
chore/domains/cloudflare-SSL-removal-when-downgrading-apps
branch
from
1662be7
to
e9b77f0
Compare
maurerbot
previously requested changes
Jul 21, 2023
|
Cosmin-Parvulescu
force-pushed
the
chore/domains/cloudflare-SSL-removal-when-downgrading-apps
branch
from
a7c7144
to
6cda509
Compare
betimshahini
approved these changes
Jul 25, 2023
betimshahini
deleted the
chore/domains/cloudflare-SSL-removal-when-downgrading-apps
branch
maurerbot
restored the
chore/domains/cloudflare-SSL-removal-when-downgrading-apps
branch
maurerbot
deleted the
chore/domains/cloudflare-SSL-removal-when-downgrading-apps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Testing
Checklist