Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(address): Await edge removal properly #2560

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(address): Await edge removal properly #2560

merged 1 commit into from
Jul 28, 2023

Conversation

betimshahini
Copy link
Contributor

Description

Await edge removal collection before calling node-deletion method.

Related Issues

Testing

  • Locally reproduce the D1 error by adding a new account and disconnecting it, now that it happens consistently; apply fix and redo, without error.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@betimshahini betimshahini marked this pull request as ready for review July 28, 2023 20:16
@betimshahini betimshahini merged commit 9708b57 into main Jul 28, 2023
12 checks passed
@betimshahini betimshahini deleted the fix/2323-d1-foreign-key-error branch July 28, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poolsar42 poolsar42 poolsar42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(passport): D1_ERROR when disconnecting account
2 participants
@betimshahini @poolsar42