Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): rename identifier tokens and break everything #2596

Merged
merged 4 commits into from
Aug 16, 2023
Merged

chore(all): rename identifier tokens and break everything #2596

merged 4 commits into from
Aug 16, 2023

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Aug 11, 2023 •
edited
Loading

Description

  • address -> account
  • access -> authorization
  • account -> identity

Related Issues

Testing

  • Everything

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl marked this pull request as draft August 11, 2023 03:35
@szkl szkl self-assigned this Aug 11, 2023
@szkl szkl requested review from poolsar42, Cosmin-Parvulescu and betimshahini and removed request for poolsar42 and Cosmin-Parvulescu August 11, 2023 03:35
@szkl szkl added the dx Indicated a developer experience issue label Aug 11, 2023
@szkl szkl force-pushed the chore/identifier-tokens branch 4 times, most recently from a684267 to 1b70694 Compare August 11, 2023 14:58
@szkl szkl requested a review from maurerbot August 11, 2023 14:58
@szkl szkl force-pushed the chore/identifier-tokens branch 14 times, most recently from 6a1c1dc to ca1e54a Compare August 14, 2023 20:43
@szkl szkl marked this pull request as ready for review August 14, 2023 20:43
@szkl szkl force-pushed the chore/identifier-tokens branch 9 times, most recently from 95ce325 to 90edd12 Compare August 16, 2023 15:24
@betimshahini betimshahini merged commit 84026e5 into main Aug 16, 2023
14 checks passed
@betimshahini betimshahini deleted the chore/identifier-tokens branch August 16, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini Awaiting requested review from betimshahini

@poolsar42 poolsar42 Awaiting requested review from poolsar42

@Cosmin-Parvulescu Cosmin-Parvulescu Awaiting requested review from Cosmin-Parvulescu

@maurerbot maurerbot Awaiting requested review from maurerbot

Assignees

@szkl szkl

Labels
dx Indicated a developer experience issue
Projects
None yet
Milestone
No milestone
2 participants
@szkl @betimshahini