fix(core): fallback to defaults if ENS entry is not available #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betimshahini
previously approved these changes
Nov 3, 2023
szkl
force-pushed
the
fix/core/crypto-profile
branch
from
9bff4f2
to
d769c0f
Compare
szkl
force-pushed
the
fix/core/crypto-profile
branch
from
d769c0f
to
6add074
Compare
betimshahini
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The utility function returns
nullto represent the missing profile.The crypto profile getter function falls back to empty default values
for the missing profile properties.
Testing
Checklist