require aggregate changed to have non empty ar id #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really because my events often override the aggregateId method to return one of the properties. In the case I reported it was a wrong property. This wouldn't have helped with that particular case. |
|
Then maybe change the getter as well?
Sascha-Oliver Prolic
Am Sa., 3. Nov. 2018 um 05:12 Uhr schrieb Jáchym Toušek <
notifications@github.com>:
… Not really because my events often override the aggregateId method to
return one of the properties. In the case I reported it was a wrong
property. This wouldn't have helped with that particular case.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYEvHe3rkMijG13VVH6dZ8gdwmSZqT-ks5urLU7gaJpZM4YMRyC>
.
|
|
A bug in the getter was what caused the event to be commited without aggregateId. Anyway it's not too important. I think you can just close it. |
|
Okay, thanks for your input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #83
ping @enumag - does that work for you?