Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import FQCNs #11

Merged
merged 3 commits into from
Jan 22, 2017
Merged

import FQCNs #11

merged 3 commits into from
Jan 22, 2017

Conversation

basz
Copy link
Member

@basz basz commented Jan 21, 2017

as requested...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.85% when pulling 74f5136 on basz:import-fqns into e04d65e on prooph:master.

prolic
prolic reviewed Jan 21, 2017
View reviewed changes
Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing

examples/register_and_change_username.php
},
'definition' => UserAggregateDefinition::class,
],
'handler' => function (array $state, Message $message): AggregateResult {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prolic see chat, I've discussed this with @basz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, this key is expected to be a command name. Second the aggregate definition is missing. Third the function Prooph\MicroDo\UserWrite\Model\User\registerWithData does not exist. So what's the point?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified this PR a little bit, if there is a problem, let's create another PR.

@prolic prolic merged commit 0212421 into prooph:master Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeliner codeliner codeliner left review comments

@prolic prolic prolic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@basz @coveralls @prolic @codeliner