Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement one stream per aggregate feature #37

Merged
merged 2 commits into from
Feb 7, 2017
Merged

implement one stream per aggregate feature #37

merged 2 commits into from
Feb 7, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Feb 7, 2017

resolves #16

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 58.537% when pulling 345a4af on one_stream_per_aggregate into eed51e0 on master.

oqq
oqq reviewed Feb 7, 2017
View reviewed changes
tests/KernelTest.php Outdated
/**
* @test
*/
public function it_loads_throws_exception_when_loading_events_with_invalid_event_store_factory(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the function name without "loads_"

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 58.537% when pulling 2087305 on one_stream_per_aggregate into eed51e0 on master.

@codeliner codeliner merged commit a230dc1 into master Feb 7, 2017
@prolic prolic deleted the one_stream_per_aggregate branch February 8, 2017 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oqq oqq oqq left review comments

@codeliner codeliner codeliner approved these changes

@basz basz Awaiting requested review from basz

@bweston92 bweston92 Awaiting requested review from bweston92

Assignees

@codeliner codeliner

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize for one stream per aggregate
4 participants
@prolic @coveralls @codeliner @oqq