Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document adding a new test #8

Closed
oxr463 opened this issue Jan 7, 2020 · 4 comments
Closed

Document adding a new test #8

oxr463 opened this issue Jan 7, 2020 · 4 comments
Assignees

Comments

@oxr463
Copy link
Contributor

oxr463 commented Jan 7, 2020

The testsuite needs lots of love, but for now, here are some steps to add a new test.

There are more than one type of test, compiled tests written in c, or shell scripts.

Also, if you take a peek at test/GNUmakefile, you will see some tests are hard-coded in there for some reason.

I recently added test/test-python01.sh, so you can use that one as a proper example.

See also: proot-me/proot#164

@oxr463 oxr463 self-assigned this Jan 7, 2020
@oxr463
Copy link
Contributor Author

oxr463 commented Jan 7, 2020

@emilio1625 does this help any?

@emilio1625
Copy link

Hey thanks! this helps a lot

@oxr463
Copy link
Contributor Author

oxr463 commented Jan 7, 2020

Also, per the release guide,

All shell scripts must pass shellcheck.

If you aren't familiar with shellcheck, then check it out, https://www.shellcheck.net

@oxr463
Copy link
Contributor Author

oxr463 commented Jan 8, 2020

Also, you can run the testsuite with V=1 for verbose. That really helps, but it is very verbose..

@oxr463 oxr463 transferred this issue from proot-me/proot Mar 30, 2020
oxr463 added a commit that referenced this issue Mar 31, 2020
@oxr463 oxr463 closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants