Introduce Field.clone method
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact event generation logic was considering attributes from elements directly and constructing new value-object based event classes directly. This does not work well because the same attribute is shared between the actual element and the newly generated event class. This commit introduces a clone method at the field level so we can copy the field safely.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 89.80% 89.81%
=======================================
Files 71 71
Lines 5996 6000 +4
Branches 1203 1203
=======================================
+ Hits 5385 5389 +4
Misses 458 458
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact event generation logic was considering attributes from elements directly and constructing new value-object based event classes directly. This does not work well because the same attribute is shared between the actual element and the newly generated event class.
This commit introduces a clone method at the field level so we can copy the field safely.