ef-themes-select empty until themes are loaded

[iris-garcia]

Hi Prot,

First of all thank you for this amazing package, I love it.

The question I have is the following, if I just load the ef-themes like this:

(add-to-list 'load-path "~/.emacs.d/.local/straight/repos/ef-themes")
(require 'ef-themes)

When I call ef-themes-select there are no candidates, is this the intention?

If so, what is the best way to populate that list without having to load each theme during initialization?

Thank you.

[protesilaos]

Hello @iris-garcia!

This is not intended behaviour. I will see to it now and report back to you.

[theherk]

I notice they are all present if I use load-theme, then afterwards, they are available in ef-themes-select.

[iris-garcia]

@theherk
First call to load-theme:

Then a call to ef-themes-select

I think the themes are not added until they are actually loaded.

[protesilaos]

@iris-garcia I just pushed the change. Yes, @theherk is correct in that load-theme would always recognise them, but the ef-themes-select didn't do that.

I have changed it now. I believe it works properly. Please give it a try.

I still plan to refine some of the internal functions in the interest of simplicity/correctness. Though that will have to wait until tomorrow morning.

[iris-garcia]

Thank you for the quick response @protesilaos, I think the logic is good, but maybe you placed the enabling of themes function in the wrong place, I still don't see the candidates (It can also be an issue in my environment).

[protesilaos]

Mea culpa! I only added it to one command, but not the other. I pushed a change now.

[iris-garcia]

I have a suggestion, can I open a PR?

[protesilaos]

Yes, sure. Though, if possible, keep the change below 15 lines. Otherwise you need to assign copyright to the Free Software Foundation.

[iris-garcia]

I can confirm that this issue is fixed, happy to close it, however I see a new one with ef-themes-load-random which may be related to this one.

[protesilaos]

I just pushed commit 50be213 which should properly fix this issue. Please let me know if this is the case.

Here is what I am loading at startup and both ef-themes-load-random and ef-themes-select do the right thing:

(require 'ef-themes)

;; The `ef-themes' provide lots of themes.  I want to pick one at
;; random when I start Emacs: the `ef-themes-load-random' does just
;; that (it can be called interactively as well).  I just check with
;; GNOME to determine if the choice should be about a light or a dark
;; theme.
(if (string-match-p
     "dark"
     (shell-command-to-string "gsettings get org.gnome.desktop.interface color-scheme"))
    (ef-themes-load-random 'dark)
  (ef-themes-load-random 'light))

(define-key global-map (kbd "<f5>") #'ef-themes-select)

Simplified:

(require 'ef-themes)

(ef-themes-load-random 'dark) ;; OR (ef-themes-load-random 'light)

(define-key global-map (kbd "<f5>") #'ef-themes-select)

[iris-garcia]

It works perfect now! Thank you @protesilaos, also for the suggestion on reading the current color-scheme of the DE to load dark or light themes.

[protesilaos]

Great!