Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow jspb.Message.GENERATE_FROM_OBJECT to be configured externally #3558

Closed
jonnyreeves opened this issue Aug 23, 2017 · 1 comment
Closed

Allow jspb.Message.GENERATE_FROM_OBJECT to be configured externally #3558

jonnyreeves opened this issue Aug 23, 2017 · 1 comment

Comments

@jonnyreeves
Copy link

The jspb.Message.GENERATE_FROM_OBJECT flag is used to control the generation of the fromObject() method in the JavaScript compiler.

IMHO the fromObject() method provides a friendlier API for JavaScript developers and I would like to be able to enable this in my project; however this feature is gated behind the testonly flag.

I would like to change this so fromObject generation can be enabled independently of the other features gated behind the testonly flag.

Would a PR that enables this functionality be welcome / be considered for landing?
@jonny-improbable
Copy link

Note this is a dupe of protocolbuffers/protobuf-javascript#96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonnyreeves @BSBandme @jtattermusch @jonny-improbable