Add a modified patch from craigcitro@ to handle namespace sharing. #1259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTN: @haberman, @craigcitro
This is based on a patch from Craig Citro. I will need some hand holding to actually build the protobuf Py lib to do some manual tests. Did not manage to do a python setup.py build/test/install on a fresh clone.
I know that the init.py files will work because I am already doing some namespace sharing in google/ and google/cloud with other packages but still this needs to be manually tested for protobuf.
Thanks,
Silviu