Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modified patch from craigcitro@ to handle namespace sharing. #1259

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

silviulica
Copy link
Contributor

ATTN: @haberman, @craigcitro
This is based on a patch from Craig Citro. I will need some hand holding to actually build the protobuf Py lib to do some manual tests. Did not manage to do a python setup.py build/test/install on a fresh clone.
I know that the init.py files will work because I am already doing some namespace sharing in google/ and google/cloud with other packages but still this needs to be manually tested for protobuf.
Thanks,
Silviu

@haberman
Copy link
Member

This passed the tests, so I'm going to merge it for now even though I have not been able to verify that it solves the problems it was intended to solve.

haberman added a commit that referenced this pull request Feb 24, 2016
Add a modified patch from craigcitro@ to handle namespace sharing.
@haberman haberman merged commit cc775f7 into protocolbuffers:master Feb 24, 2016
@silviulica
Copy link
Contributor Author

Any chance we can get this released (so we take dependencies). I can manually test if you give me instructions how to build the Python protobuf package or just point me to a tarball with the change.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Feb 24, 2016

@silviulica you can build the python package by running:

$ ./setup.py build sdist

In the python directory.

@silviulica
Copy link
Contributor Author

When I do that I get this error:
google/protobuf/any.proto:31:10: Unrecognized syntax identifier "proto3". This parser only recognizes "proto2".

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Feb 25, 2016

oh, you need to install the protocol compiler first:
https://github.com/google/protobuf/blob/master/src/README.md

The error message is from a pre-installed protocol compiler on your computer which seems to be an old version and can not understand proto3 syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants