Missed LIBPROTOC_EXPORT for GRPC added #2227
Conversation
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Fix #2219 |
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
CLAs look good, thanks! |
| string ClassName(const Descriptor* descriptor); | ||
| string ClassName(const Descriptor* descriptor, string* out_suffix_added); | ||
| string LIBPROTOC_EXPORT ClassName(const Descriptor* descriptor); | ||
| string LIBPROTOC_EXPORT ClassName(const Descriptor* descriptor, string* out_suffix_added); | ||
| string EnumName(const EnumDescriptor* descriptor); |
There was a problem hiding this comment.
Can you mark all functions in this file as LIBPROTOC_EXPORT?
There was a problem hiding this comment.
Ok, what with other files?
There was a problem hiding this comment.
Yeah, please add LIBPROTOC_EXPORT to all public functions in charp_names.h as well. Right now the GetOutputFile() function in csharp_names.h is also missing it.
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
@xfxyjwf any news with this PR? |
|
Can one of the admins verify this patch? |
|
Thanks, the change looks good. |
Missed LIBPROTOC_EXPORT for GRPC added
No description provided.