Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed LIBPROTOC_EXPORT for GRPC added #2227

Merged
merged 2 commits into from
Dec 16, 2016

Conversation

KindDragon
Copy link
Contributor

No description provided.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@KindDragon
Copy link
Contributor Author

Fix #2219

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@KindDragon KindDragon changed the base branch from 3.1.x to master October 15, 2016 14:41
@KindDragon KindDragon closed this Oct 15, 2016
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

CLAs look good, thanks!

string ClassName(const Descriptor* descriptor);
string ClassName(const Descriptor* descriptor, string* out_suffix_added);
string LIBPROTOC_EXPORT ClassName(const Descriptor* descriptor);
string LIBPROTOC_EXPORT ClassName(const Descriptor* descriptor, string* out_suffix_added);
string EnumName(const EnumDescriptor* descriptor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark all functions in this file as LIBPROTOC_EXPORT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, what with other files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, please add LIBPROTOC_EXPORT to all public functions in charp_names.h as well. Right now the GetOutputFile() function in csharp_names.h is also missing it.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@KindDragon
Copy link
Contributor Author

@xfxyjwf any news with this PR?

@bazel-io
Copy link

Can one of the admins verify this patch?

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Dec 16, 2016

Thanks, the change looks good.

@xfxyjwf xfxyjwf merged commit f39cf88 into protocolbuffers:master Dec 16, 2016
@KindDragon KindDragon deleted the 3.1.x branch December 16, 2016 22:05
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Missed LIBPROTOC_EXPORT for GRPC added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants