Added lots of decoder tests and fixed lots of bugs. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To @scwhittle. I'm not going to worry about the Coveralls "failure." |
| @@ -558,9 +571,9 @@ uint32_t Hash(const string& proto, const string* expected_output, size_t seam1, | |||
|
|
|||
| void CheckBytesParsed(const upb::pb::Decoder& decoder, size_t ofs) { | |||
| // We could have parsed as many as 10 bytes fewer than what the decoder | |||
| // previously accepted, since we can buffer up to 10 partial bytes internally | |||
| // previously accepted, since we can buffer up to 12 partial bytes internally | |||
There was a problem hiding this comment.
Lots of different numbers 10, 12, 14
should they all be 14? Maybe with explanation on where 14 was calculated
| @@ -257,15 +286,14 @@ size_t upb_pbdecoder_suspend(upb_pbdecoder *d) { | |||
| d->ptr = d->residual; | |||
| return 0; | |||
| } else { | |||
| size_t consumed; | |||
| size_t ret = d->size_param - (d->end - d->checkpoint); | |||
haberman
added a commit
that referenced
this pull request
Aug 19, 2015
Added lots of decoder tests and fixed lots of bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.