Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark-callable-contracts rule is firing a false positive on emitting events #116

Closed
habdelra opened this issue May 14, 2019 · 0 comments · Fixed by #117
Closed

mark-callable-contracts rule is firing a false positive on emitting events #116

habdelra opened this issue May 14, 2019 · 0 comments · Fixed by #117

Comments

@habdelra
Copy link
Contributor

The mark-callable-contracts rule is being triggered against emitting events, as events are camel-cased very similarly to contracts. We should update this rule so that it does not get triggered by emitting an event. Take for instance this example:

contract A {
  event UpdatedToken();

  function b() public {
    emit UpdatedToken(); // This line triggers mark-callable-contracts
  }

}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant