Fix leak in unsubscribe #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix only partially addressed the per-exchange leak that we were observing. This should fix that logic such that the request properly unsubscribes on completion. There is still potentially another issue that remains related to an obervation of an unexpectedly high number of registered connections, which may mean that we are not properly detecting when a connection is already listening, TBD. Signed-off-by: Greg Haskins <greg@manetu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix only partially addressed the per-exchange leak that
we were observing. This should fix that logic such that the request
properly unsubscribes on completion.
There is still potentially another issue that remains related to an
obervation of an unexpectedly high number of registered connections,
which may mean that we are not properly detecting when a connection
is already listening, TBD.
Signed-off-by: Greg Haskins greg@manetu.com