tileset: fix population parsing of commas. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
nvkelso
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
LGTM
Longer term there's a lot of junk in OSM tag values that can be sanitized.
Looks like there are other useful built-in functions for sanitizing, like:
- meters - not sure why this isn't called
parseMeters? - parseRoundInt which uses regex in TO_ROUND_INT_SUBSTRING_PATTERN.
So any new logic should be compatible with an upstream merge there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nvkelso this ignores OSM population tag values that have commas in them (though we should either fix them upstream or handle those correctly)