-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unusable pmtiles file generated if source mbtiles file has no metadata #60
Comments
Can you share the Is it possible that the center/bounds are defaulting to the world and it just not visible at the scale when loaded in JS? |
I dug into this a bit more, hopefully this explains it better:
I'd suggest that the pmtiles command should refuse to create files with an invalid bounding box such as this, or at least issue a warning. I'd also suggest that the JS library should probably issue a warning if the pmtiles file has an invalid bounding box. Result of `pmtiles show`
|
We can either
I have a slight preference for 2 because the MBTiles spec uses the SHOULD language (a valid bounds is not a hard requirement) |
…60] * error out if bounds is degenerate (zero or less area)
opened a PR: #77
|
@russss this should be resolved by https://github.com/protomaps/go-pmtiles/releases/tag/v1.10.0 which will fail if a zero-area bounds is passed, but accept no bounds. Please re-open if this is still an issue! |
I think if you use the
pmtiles
command line tool to convert anmbtiles
into apmtiles
file, and thembtiles
doesn't have bounds/center metadata, then you get a successfully-generatedpmtiles
file which the JS library (at least) will silently ignore.I'm 80% sure this is what's happening, but I don't have the time to dig into the code to confirm at the moment (sorry).
The text was updated successfully, but these errors were encountered: