Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NewFileBucket func #145

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

jzs
Copy link
Contributor

@jzs jzs commented Feb 22, 2024

Enables the possibility to initialize FileBuckets from external packages

Enables the possibility to initialize FileBuckets from external packages
@jzs
Copy link
Contributor Author

jzs commented Feb 22, 2024

I was working on my own Bucket implementations and wanted to support both FileBucket and my own custom SftpBucket implementation when initializing a new server so i needed an exposed way of initializing FileBuckets

@bdon
Copy link
Member

bdon commented Feb 25, 2024

@msbarry would it be cleaner here to make Path an exported field?

@msbarry
Copy link
Contributor

msbarry commented Feb 25, 2024

@msbarry would it be cleaner here to make Path an exported field?

Only if you want it to be readable. Otherwise it's kind of nice to have a function that all creation goes through in case you want to insert some logic, path normalization, etc.

@bdon bdon merged commit 245df71 into protomaps:main Feb 25, 2024
3 of 4 checks passed
@bdon
Copy link
Member

bdon commented Feb 25, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants