Adds heroku deployment workflow for rails app only #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ####After all this... | ||
| ...why not add `rail_12factor` gem to Gemfile? *If you're not concerned with Rails logs being written to file, `config.serve_static_assets = true` is all you need.* | ||
|
|
||
| ...I use `secrets.yml` instead of `application.yml`? *It's a known limitation for using Heroku. Best stick in using `ENV[___]` approach on this one.* |
There was a problem hiding this comment.
# secrets.yml
production:
secret_key_base: <%= ENV['SECRET_KEY_BASE'] || '...' %>There was a problem hiding this comment.
@rstacruz that is also a cool approach, but we really have to agree on the most foolproof approach in handling credentials. So far we use secrets.yml the same manner as application.yml, we do not checkin these files into repo(adding them at .gitignore).
Should we instead:
- Check in secrets.yml as part of the repo.
- Use application.yml as well, but not included in repo
- All sensitive credentials set from application.yml are to be set from secrets.yml
- Use
Rails.application.secretsin calling these credentials - Refrain from using
ENV[]
rstacruz
added a commit
that referenced
this pull request
May 20, 2015
Adds heroku deployment workflow for rails app only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.