Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BSC mainnet OAR #107

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

oliviera9
Copy link
Contributor

At the moment, contract deployment would fail for BSC, without explicitly setting OAR.
This PR updates the API by adding the OAR setting for BSC.
The additional line oraclize_setNetworkName("bsc_mainnet"); should be required for Ledger Proof. Need to test this.

Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

@oliviera9 oliviera9 merged commit 337f868 into provable-things:master Jul 7, 2022
@oliviera9 oliviera9 deleted the feat/add-bsc-oar branch July 7, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants