Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the oraclizeAPI modifier to only update the connector address in storage if it has changed. #17

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Update to the oraclizeAPI modifier to only update the connector address in storage if it has changed. #17

merged 1 commit into from
Oct 11, 2017

Conversation

AdamJLemmon
Copy link
Contributor

Current implementation writes the connector address to storage for every query.

This change only does so if the address has changed and therefore saves a storage write on each query.

@D-Nice
Copy link
Contributor

D-Nice commented Oct 10, 2017

LGTM!

OAR.getAddress() is not assigned to variable for greater gas saving, as updates to the connector itself should be quite rare.

marcogiglio
marcogiglio reviewed Oct 10, 2017
View reviewed changes
Copy link
Contributor

@marcogiglio marcogiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, I think we can merge ;)

@bertani bertani merged commit 7e9d1f7 into master Oct 11, 2017
@D-Nice D-Nice deleted the adamjlemmon-oraclizeAPI-modifier branch July 2, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcogiglio marcogiglio marcogiglio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdamJLemmon @D-Nice @marcogiglio @bertani