Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/natspec doxygen bug #92

Merged
merged 3 commits into from
Jun 25, 2019
Merged

fix/natspec doxygen bug #92

merged 3 commits into from
Jun 25, 2019

Conversation

gskapka
Copy link
Collaborator

@gskapka gskapka commented Jun 24, 2019

...that can cause compiler issues in some rare cases.

It's the second time it's happened and both times were difficult to track down. So rather than waste time trying, this PR just removes the offending @ tag. The credit to Alex for his ecrecover remains, just sans twitter handle.

@gskapka gskapka self-assigned this Jun 24, 2019
@gskapka gskapka requested a review from D-Nice June 24, 2019 09:06
@gskapka gskapka added bug quick fix Small changes that make quick fixes. labels Jun 24, 2019
@gskapka
Copy link
Collaborator Author

gskapka commented Jun 25, 2019

Update:

Force-pushed this after a rebase onto the new master after the Provable-branding PR got merged in. It now should merge cleanly again.5

Copy link
Contributor

@D-Nice D-Nice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gskapka gskapka merged commit 831f412 into master Jun 25, 2019
@gskapka gskapka deleted the fix/natspec-doxygen-bug branch June 25, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug quick fix Small changes that make quick fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants