Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): test caller-pays-for-query truffle example in CI #93

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

gskapka
Copy link
Collaborator

@gskapka gskapka commented Jun 25, 2019

...per title.

@gskapka gskapka added enhancement quick fix Small changes that make quick fixes. labels Jun 25, 2019
@gskapka gskapka self-assigned this Jun 25, 2019
@D-Nice
Copy link
Contributor

D-Nice commented Jun 25, 2019

merging if tests pass

@gskapka
Copy link
Collaborator Author

gskapka commented Jun 26, 2019

merging if tests pass

Build is failing

I chuckled. More so when I looked and it's not this new example causing the failure, it's good old pesky url-requests.

I have zero clue now why the computation datasource in that example occasionally returns nothing from the POST, and that fix I pushed to that clearly hasn't solved the intermittent issue. We should probably drop it from the CI (again) and go back to the drawing board re that particular example.

This new Truffle example however should be absolutely fine in the CI, and it passed here with flying colours.

@gskapka gskapka force-pushed the feat/add-new-truffle-example-to-CI branch from d22750f to 2553c10 Compare June 26, 2019 10:26
@gskapka
Copy link
Collaborator Author

gskapka commented Jun 26, 2019

Have removed that last commit re-enabling the intermittently failing url-request test, and forced the branch. Better this way then ending up with two commits in master where the second just undoes the first.

☢️ Branch forced - please re-pull.

This way this PR can be merged and closed, and I've created a new issue re the url-requests so we can deal with that separately instead.

Let me know if this PR and the process above both LGTY @D-Nice and we can get this merged.

@D-Nice D-Nice self-requested a review June 26, 2019 16:37
Copy link
Contributor

@D-Nice D-Nice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging

@D-Nice D-Nice merged commit 72c542d into master Jun 26, 2019
@D-Nice D-Nice deleted the feat/add-new-truffle-example-to-CI branch June 26, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement quick fix Small changes that make quick fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants