Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto to JsonSchema well-known types support #3088

Merged
merged 12 commits into from
Jan 16, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Dec 16, 2022

  1. Add support for predefined (well-known) protobuf types.
  2. preservingProtoFieldNames mode is enabled for proto messages formatting to fit proto file's message's field names
  3. Invalid oneof-processing logic removed
  4. Integer type's ranges added
  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

2. `preservingProtoFieldNames` mode is enabled for proto messages formatting to fit proto file's message's field names
3. Invalid oneof-processing logic removed
@iliax iliax requested a review from a team as a code owner December 16, 2022 20:35
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Dec 16, 2022
@iliax iliax linked an issue Dec 17, 2022 that may be closed by this pull request
2. format added to Timestamp protobuf type
@iliax iliax requested a review from a team as a code owner December 19, 2022 13:04
@Haarolean Haarolean added type/bug Something isn't working scope/backend scope/frontend and removed status/triage Issues pending maintainers triage labels Jan 5, 2023
@Haarolean Haarolean changed the title ISSUE-3087: Protobuf -> JsonSchema well-known types support Proto to JsonSchema well-known types support Jan 5, 2023
iliax added 2 commits January 16, 2023 14:12
…7_protowellknowntypes

� Conflicts:
�	kafka-ui-react-app/package.json
�	kafka-ui-react-app/pnpm-lock.yaml
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@iliax iliax merged commit 7c6d04b into master Jan 16, 2023
@iliax iliax deleted the ISSUE-3087_protowellknowntypes branch January 16, 2023 10:49
@Haarolean Haarolean linked an issue Feb 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants