-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto to JsonSchema well-known types support #3088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. `preservingProtoFieldNames` mode is enabled for proto messages formatting to fit proto file's message's field names 3. Invalid oneof-processing logic removed
2. format added to Timestamp protobuf type
Mgrdich
approved these changes
Dec 19, 2022
Haarolean
added
type/bug
Something isn't working
scope/backend
scope/frontend
and removed
status/triage
Issues pending maintainers triage
labels
Jan 5, 2023
Haarolean
changed the title
ISSUE-3087: Protobuf -> JsonSchema well-known types support
Proto to JsonSchema well-known types support
Jan 5, 2023
Haarolean
approved these changes
Jan 5, 2023
…7_protowellknowntypes � Conflicts: � kafka-ui-react-app/package.json � kafka-ui-react-app/pnpm-lock.yaml
Kudos, SonarCloud Quality Gate passed! |
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preservingProtoFieldNames
mode is enabled for proto messages formatting to fit proto file's message's field namesWhat changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)