Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] Fix HTTP 414 with a big partitions list selected #3145

Merged
merged 3 commits into from
Jan 12, 2023
Merged

[FE] Fix HTTP 414 with a big partitions list selected #3145

merged 3 commits into from
Jan 12, 2023

Conversation

Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented Dec 26, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Mgrdich Mgrdich requested a review from a team as a code owner December 26, 2022 11:53
@Mgrdich Mgrdich self-assigned this Dec 26, 2022
@Mgrdich Mgrdich linked an issue Dec 26, 2022 that may be closed by this pull request
HTTP 414 with a big partitions list selected #3115
Open
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Dec 26, 2022
@Mgrdich Mgrdich added type/bug Something isn't working scope/frontend and removed status/triage Issues pending maintainers triage labels Dec 26, 2022
@Mgrdich Mgrdich force-pushed the issues/3115_partition_issue_in_messages branch 2 times, most recently from 9089043 to 2c1eb04 Compare January 3, 2023 11:49
@Mgrdich Mgrdich force-pushed the issues/3115_partition_issue_in_messages branch from 2c1eb04 to 9fe8726 Compare January 10, 2023 08:33
@Haarolean Haarolean requested a review from a team January 11, 2023 02:34
@Haarolean Haarolean added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Jan 11, 2023
@github-actions
Copy link

Custom deployment will be available at http://pr3145.internal.kafka-ui.provectus.io

@armenuikafka
Copy link

@Haarolean seems http://pr3145.internal.kafka-ui.provectus.io/ is not available

@Haarolean Haarolean added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels Jan 11, 2023
@github-actions
Copy link

Custom deployment removed

@github-actions
Copy link

Custom deployment will be available at http://pr3145.internal.kafka-ui.provectus.io

@armenuikafka armenuikafka removed their assignment Jan 12, 2023
@armenuikafka armenuikafka removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Jan 12, 2023
@github-actions
Copy link

Custom deployment removed

@Haarolean Haarolean merged commit aeda502 into master Jan 12, 2023
@Haarolean Haarolean deleted the issues/3115_partition_issue_in_messages branch January 12, 2023 15:34
@Haarolean Haarolean changed the title Filters Fixing the seekTo parameter when all the partitions are selected [FE] Fix HTTP 414 with a big partitions list selected Jan 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armenuikafka armenuikafka armenuikafka approved these changes

@workshur workshur workshur approved these changes

Assignees

@Mgrdich Mgrdich

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP 414 with a big partitions list selected
4 participants
@Mgrdich @armenuikafka @workshur @Haarolean