Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer groups loading performance impr #3188

Merged
merged 11 commits into from
Jan 12, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Jan 3, 2023

  1. ACL applied on entire group list
  2. loading all group descriptions before paginating only for MEMBERS sorting
  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

1. ACL applied on entire group list
2. loading all group descriptions before paginating only for MEMBERS sorting
@iliax iliax requested a review from a team as a code owner January 3, 2023 12:25
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 3, 2023
@iliax iliax linked an issue Jan 3, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Image published at public.ecr.aws/provectus/kafka-ui-custom-build:3188

@Haarolean Haarolean added type/bug Something isn't working scope/backend and removed status/triage Issues pending maintainers triage labels Jan 5, 2023
@Haarolean Haarolean changed the title ISSUE-3176: Consumer groups loading performance impr Consumer groups loading performance impr Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Image tag public.ecr.aws/provectus/kafka-ui-custom-build:3188 has been removed

iliax and others added 5 commits January 8, 2023 13:34
1. batch listConsumerGroupOffsets method implemented
2. describeConsumerGroups parallelized
3. minor improvements in ReactiveAdminClient
4. (not related to perf) ConsumerGroupMapper messagesBehind setting fixed
@iliax iliax merged commit 578468d into master Jan 12, 2023
@iliax iliax deleted the ISSUE-3176_cg_loading_performance branch January 12, 2023 19:14
@yardenshoham
Copy link
Contributor

How can one add a sort by messages behind? As opposed to NAME, STATE, and MEMBERS - we don't have the messages behind in the loadSortedDescriptions function

@Haarolean
Copy link
Contributor

How can one add a sort by messages behind? As opposed to NAME, STATE, and MEMBERS - we don't have the messages behind in the loadSortedDescriptions function

#3468

@yardenshoham
Copy link
Contributor

Yes, I opened it. Just trying to see how it can be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumers: performance loading consumers
3 participants