Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking messages filtering by timestamp within messages/topic #3195

Merged
merged 45 commits into from
Jan 13, 2023
Merged

Checking messages filtering by timestamp within messages/topic #3195

merged 45 commits into from
Jan 13, 2023

Conversation

anezboretskiy
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@anezboretskiy anezboretskiy added scope/QA Manual QA scope/AQA Vlad really needed a separate label labels Jan 5, 2023
@anezboretskiy anezboretskiy requested a review from a team as a code owner January 5, 2023 11:32
@anezboretskiy anezboretskiy self-assigned this Jan 5, 2023
@anezboretskiy anezboretskiy linked an issue Jan 5, 2023 that may be closed by this pull request
[e2e]Checking messages filtering by Timestamp within Messages/Topic #3105
Closed
@anezboretskiy
fix AfterAll class in ConnectorsTests
050ac0d
@anezboretskiy
Added Locale.Us for DateTimeFormatter pattern
1230cb0
@anezboretskiy
refactored equals to isEqual checkingMessageFilteringByTimestamp()
ef6901f
@anezboretskiy
Added argument for locale as "--lang=es"
ace7b44
@anezboretskiy
Deleted seconds from setTime(), refactored pattern of timestamp
61728ef
@anezboretskiy
Refactored assertions of checkingMessageFilteringByTimestamp()
eb92617
@anezboretskiy
Revert seekTypeField locator
58244e9
@anezboretskiy
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
235f9ce 
…ithin_messages/topic
@anezboretskiy
Refactored hh to HH in pattern
5df382c
@anezboretskiy
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
8388307 
…ithin_messages/topic
@anezboretskiy
Refactored waitUntilScreenReady() in TopicDetails
a2f9433
@anezboretskiy
Refactored topicListHeader locator
eb4555c
@anezboretskiy
Refactored of TopicMessagesTests
edc10e2
VladSenyuta
VladSenyuta suggested changes Jan 10, 2023
View reviewed changes
kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/services/ApiService.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/suite/connectors/ConnectorsTests.java Show resolved Hide resolved
kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicDetails.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicDetails.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicDetails.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicDetails.java Outdated Show resolved Hide resolved
kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/pages/topic/TopicDetails.java Outdated Show resolved Hide resolved
VladSenyuta and others added 3 commits January 10, 2023 09:59
@VladSenyuta
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
605eae7 
…ithin_messages/topic

# Conflicts:
#	kafka-ui-e2e-checks/src/main/java/com/provectus/kafka/ui/services/ApiService.java
#	kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/base/BaseTest.java
@VladSenyuta
fix mc
c5b9544
@anezboretskiy
resolve conversation
df6be75
@anezboretskiy anezboretskiy linked an issue Jan 11, 2023 that may be closed by this pull request
Wrong time format of Timestamp filter calendar #3215
Open
@anezboretskiy anezboretskiy removed a link to an issue Jan 11, 2023
Wrong time format of Timestamp filter calendar #3215
Open
Haarolean and others added 13 commits January 12, 2023 10:22
@Haarolean
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
7104702 
…ithin_messages/topic
@anezboretskiy
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
b22c13a 
…ithin_messages/topic

# Conflicts:
#	kafka-ui-e2e-checks/src/test/java/com/provectus/kafka/ui/suite/topics/TopicMessagesTests.java
@anezboretskiy
Merge remote-tracking branch 'origin/Checking_messages_filtering_by_t…
e9d309d 
…imestamp_within_messages/topic' into Checking_messages_filtering_by_timestamp_within_messages/topic
@anezboretskiy
Fix spinner locator
d0ceb73
@anezboretskiy
revert clickSubmitFiltersBtnMessagesTab() method
6131b1f
@anezboretskiy
Added disabled annotation for checkingMessageFilteringByTimestamp()
2941f87
@anezboretskiy
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
63e48f9 
…ithin_messages/topic
@anezboretskiy
Resolve conversation
c383d2d
@anezboretskiy
Refactored waitUntilSpinnerDisappear()
fb27634
@anezboretskiy
Reformat methods order
d3ebac6
@anezboretskiy
Disabled and refactored checkingMessageFilteringByOffset()
5aa1618
@anezboretskiy
Merge branch 'master' into Checking_messages_filtering_by_timestamp_w…
f936ecf 
…ithin_messages/topic
@anezboretskiy
Uncommented AfterAllClass
8b18def
@VladSenyuta VladSenyuta merged commit a03b684 into master Jan 13, 2023
@VladSenyuta VladSenyuta deleted the Checking_messages_filtering_by_timestamp_within_messages/topic branch January 13, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladSenyuta VladSenyuta VladSenyuta approved these changes

Assignees

@anezboretskiy anezboretskiy

Labels
scope/AQA Vlad really needed a separate label scope/QA Manual QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e]Checking messages filtering by Timestamp within Messages/Topic
3 participants
@anezboretskiy @VladSenyuta @Haarolean