Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Fix case-sensitive search in broker's topics (Closes #3043) #3276

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

BatuhanKucukali
Copy link
Contributor

@BatuhanKucukali BatuhanKucukali commented Jan 27, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@BatuhanKucukali BatuhanKucukali requested a review from a team as a code owner January 27, 2023 22:25
@Haarolean Haarolean linked an issue Jan 30, 2023 that may be closed by this pull request
@Haarolean Haarolean added type/bug Something isn't working scope/backend labels Jan 30, 2023
@Haarolean Haarolean self-assigned this Jan 30, 2023
@Haarolean
Copy link
Contributor

@BatuhanKucukali thanks for the contribution!

@Haarolean Haarolean merged commit 1b09251 into provectus:master Jan 31, 2023
@BatuhanKucukali
Copy link
Contributor Author

Thank you @Haarolean

@BatuhanKucukali BatuhanKucukali deleted the issues/3043 branch May 23, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is case-sensitive for Brokers configs and Topics
2 participants